[PM-16937] Resolved Circular Dependency issues for Billing #12861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, no security vulnerabilities found in this Pull Request |
cturnbull-bitwarden
force-pushed
the
billing/PM-16937/circular-dependency
branch
from
9e5739d to
86a2e2d
Compare
cturnbull-bitwarden
force-pushed
the
billing/PM-16937/circular-dependency
branch
from
86a2e2d to
e4a1e12
Compare
amorask-bitwarden
requested changes
Jan 16, 2025
| } | ||
|
|
||
| try { | ||
| const descriptorCode = `${this.verifyBankForm.value.amount1}${this.verifyBankForm.value.amount2}`; |
There was a problem hiding this comment.
❌ We don't use micro-deposits anymore. The verify-bank-account.component handles this. If it's causing a circular dependency, it can presumably just be moved to web.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16937
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes